Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use condition properly fix #1917 #3086

Closed
wants to merge 1 commit into from
Closed

use condition properly fix #1917 #3086

wants to merge 1 commit into from
+2 −3

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Dec 28, 2018 •
edited
Loading

What is the purpose of the change

use condition properly fix #1917

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@carryxyh
Copy link
Member

Wrong pr.

@carryxyh carryxyh closed this Dec 28, 2018
@CrazyHZM CrazyHZM deleted the useCondition branch December 28, 2018 03:34
@codecov-io
Copy link

Codecov Report

Merging #3086 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3086      +/-   ##
============================================
+ Coverage     63.43%   63.45%   +0.02%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28261    28261              
  Branches       4820     4820              
============================================
+ Hits          17926    17932       +6     
+ Misses         8057     8039      -18     
- Partials       2278     2290      +12
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/registry/redis/RedisRegistry.java 39.26% <0%> (+6.49%) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-2.18%) 0% <0%> (ø)
...dubbo/metadata/support/AbstractMetadataReport.java 69.35% <0%> (-1.62%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 71.81% <0%> (-1.35%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.82% <0%> (-1.13%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea4fa5...79af072. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Condition is not properly used ?
3 participants
@CrazyHZM @carryxyh @codecov-io